Refactor limayaml.Save and store.SaveYAML → limayaml.Marshal #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`store.SaveYAML` was the only caller of `limayaml.Save`, and was only called from `main.validateAction`. The name `Save` implies writing to a file, so `Marshal` seems like a more logical choice for the name. And since it is marshalling `limayaml` structs it should be in the `limayaml` package and not in `store`. Also move `limayaml.unmarshalYAML` from `load.go` to `marshal.go` for consistency. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
lima-marshal
branch
from
bd48227
to
2edcf1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.SaveYAMLwas the only caller oflimayaml.Save, and was only called frommain.validateAction.The name
Saveimplies writing to a file, soMarshalseems like a more logical choice for the name. And since it is marshallinglimayamlstructs it should be in thelimayamlpackage and not instore.Also move
limayaml.unmarshalYAMLfromload.gotomarshal.gofor consistency.I was wondering if
load.goandmarshal.goshould be combined into a single file, but kept them separate for now.I also feel like
store.LoadYAMLByFilePathshould probably belong in thelimayamlpackage, but am not sure.